Certtf 756 display number of jobs #853
Conversation
…exist across all agent queues
…xed the agent detail page, updated the queue description to match the display of the queue list page (blank when no description).
…port of adding more human readable YAML output format for displaying job counts, and included documentation for the various uses of the agent-status command.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 71.38% 70.99% -0.40%
==========================================
Files 108 108
Lines 9674 9533 -141
Branches 860 844 -16
==========================================
- Hits 6906 6768 -138
- Misses 2595 2596 +1
+ Partials 173 169 -4
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
rene-oromtz
left a comment
rene-oromtz
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
I just reviewed an added some comment, personally, I think we should skip the modifications in the CLI as this would be a breaking change.
I think the visual aid in the UI is useful but if we were to get the number or jobs in the queue, we already have queue_status which could be scripted with the queues from agent_status.
Also, thanks for adding the docs! I think we also should create a separate issue to document more properly the CLI...
I looked at it this way: if looping over a "list" and now looping over a "dictionary" the new keys will be the same as the former values would have been. I could add another argument to include the number of waiting jobs, but that is inconsistent with providing all the data. The yaml format is much more human readable out of the box, and there was already yaml support for other commands, I merely expanded upon it. Another option is to support the number of jobs in the yaml format, and skip the json format. I find it strange that we feed in yaml files but then spit out json. |
ajzobro
force-pushed
the
CERTTF-756-display-number-of-jobs
branch
from
6125eb2 to
651ba81
Compare
Co-authored-by: rene-oromtz <157750458+rene-oromtz@users.noreply.github.com>
…s' into CERTTF-756-display-number-of-jobs
rene-oromtz
left a comment
rene-oromtz
left a comment
There was a problem hiding this comment.
This looks good to me!
…56-display-number-of-jobs
…56-display-number-of-jobs
…56-display-number-of-jobs
Description
Converted the list of queues displayed on the agent detail page into a table (matching the format of the queue_detail page exactly).
Resolved issues
Resolves CERTF-756.
Documentation
No documentation changes required for web interface change.
Web service API changes
N/A
Tests
Updated
server/devel/create_sample_data.pyto allow for a random number of queues to be attributed to each agent for better testing.